From a61fa8289e9aba3823242a53ec44569948afc4c5 Mon Sep 17 00:00:00 2001
From: Jeff Smith <jeff@unbiasedgeek.com>
Date: Sun, 19 Apr 2026 11:34:30 -0600
Subject: [PATCH] test(logging): cover AccessLogFilter contract (#27)

---
 tests/test_logging.py | 49 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/tests/test_logging.py b/tests/test_logging.py
index f0401dd..e6a1086 100644
--- a/tests/test_logging.py
+++ b/tests/test_logging.py
@@ -40,3 +40,52 @@ def test_log_config_emits_json_with_required_fields():
     assert payload["logger"] == "tests.logging_smoke"
     assert payload["message"] == "smoke message"
     assert "timestamp" in payload
+
+
+def test_access_log_filter_enriches_record():
+    from quartermaster.logging_config import AccessLogFilter
+
+    record = logging.LogRecord(
+        name="uvicorn.access",
+        level=logging.INFO,
+        pathname=__file__,
+        lineno=0,
+        msg='%s - "%s %s HTTP/%s" %d',
+        args=("127.0.0.1:1234", "GET", "/healthz", "1.1", 200),
+        exc_info=None,
+    )
+
+    assert AccessLogFilter().filter(record) is True
+    assert record.event == "http_request"
+    assert record.method == "GET"
+    assert record.path == "/healthz"
+    assert record.status == 200
+    assert record.client_ip == "127.0.0.1:1234"
+
+
+def test_access_log_filter_passes_through_non_access_records():
+    """Non-access records (args tuple shape mismatch) are kept, unmodified."""
+    from quartermaster.logging_config import AccessLogFilter
+
+    record = logging.LogRecord(
+        name="quartermaster",
+        level=logging.INFO,
+        pathname=__file__,
+        lineno=0,
+        msg="regular app log",
+        args=None,
+        exc_info=None,
+    )
+
+    assert AccessLogFilter().filter(record) is True
+    assert not hasattr(record, "event") or record.event is None
+    assert not hasattr(record, "method") or record.method is None
+
+
+def test_log_config_loads_via_dictconfig():
+    """Verify the whole LOG_CONFIG passes logging.config.dictConfig without error."""
+    import logging.config
+
+    from quartermaster.logging_config import LOG_CONFIG
+
+    logging.config.dictConfig(LOG_CONFIG)