From fe419fe8025e4c6de3f18d5fbd7ac3e6db221b29 Mon Sep 17 00:00:00 2001 From: archeious Date: Fri, 17 Apr 2026 19:12:43 -0600 Subject: [PATCH] refactor(service): remove set_entry_notes, superseded by update_entry (#21) --- src/quartermaster/service.py | 11 ----------- tests/test_notes.py | 10 ---------- 2 files changed, 21 deletions(-) diff --git a/src/quartermaster/service.py b/src/quartermaster/service.py index 5eff831..7fc0d92 100644 --- a/src/quartermaster/service.py +++ b/src/quartermaster/service.py @@ -115,17 +115,6 @@ def _clean_notes(raw: str | None) -> str | None: return stripped if stripped else None -def set_entry_notes( - db: Session, entry_id: int, notes: str | None -) -> Entry | None: - entry = db.get(Entry, entry_id) - if entry is None: - return None - entry.notes = _clean_notes(notes) - db.commit() - db.refresh(entry) - return entry - def update_entry( db: Session, diff --git a/tests/test_notes.py b/tests/test_notes.py index 72731f4..bfcbe7c 100644 --- a/tests/test_notes.py +++ b/tests/test_notes.py @@ -24,16 +24,6 @@ def test_add_entry_strips_and_nulls_empty_notes(db): assert entry.notes is None -def test_set_entry_notes_updates(db): - entry = service.add_entry(db, Section.food, "Groceries", Decimal("400.00")) - updated = service.set_entry_notes(db, entry.id, "weekly Costco run") - assert updated is not None - assert updated.notes == "weekly Costco run" - - -def test_set_entry_notes_missing_returns_none(db): - assert service.set_entry_notes(db, 9999, "oops") is None - def test_snapshot_copies_notes(db): service.add_entry(